search

dhall-lang / dhall-to-cabal

Compile Dhall expressions to Cabal files
MIT License
100 stars 19 forks source link

When reading from a file, interpret imports relative to that file #115

Closed quasicomputational closed 6 years ago

quasicomputational commented 6 years ago

Closes #114

This only works against dhall-haskell HEAD, so it shouldn't be merged yet. Pre-requisite for #113.

quasicomputational commented 6 years ago

OK, the tests now do the Right Thing, and this now works with dhall-haskell HEAD. Our API is still changing, but at least we're not juggling multiple FilePath arguments any more.

We already transitively depend on lens so adding a direct dependency shouldn't be a problem, even though it's just for set.

quasicomputational commented 6 years ago

Dhall 1.16 is out and it works locally for me. I think this just needs for the Nix stuff to be bumped.

ocharles commented 6 years ago

Sweet, will try and get on top of this in the week.

On Sun, 22 Jul 2018, 12:48 pm quasicomputational, notifications@github.com wrote:

Dhall 1.16 is out and it works locally for me. I think this just needs for the Nix stuff to be bumped.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/dhall-lang/dhall-to-cabal/pull/115#issuecomment-406859894, or mute the thread https://github.com/notifications/unsubscribe-auth/AABRjqQHHKT-T1aoa6WdO8U61yjQxOwjks5uJGaOgaJpZM4VQZUu .

ocharles commented 6 years ago

I'm on board with this other than the microlens comment.

quasicomputational commented 6 years ago

OK, pushed, plus fixing stack.yaml that I broke in the process.

Sort of funny that we've got lens, lens-family-core and microlens all in our dependency graph now.