Add missing dhall/types/BuildInfo.dhall to extra-source-files.

dhall-lang / dhall-to-cabal

Compile Dhall expressions to Cabal files

MIT License

100 stars 19 forks source link

Closed quasicomputational closed 6 years ago

quasicomputational commented 6 years ago

I guess no-one has been testing the sdists, so this was only uncovered by Stackage.

Should fix commercialhaskell/stackage#3899.

quasicomputational commented 6 years ago

Some thoughts on how we might prevent this happening again:

Doing sdist -> test the sdist on CI.
Once Cabal 2.4 is out and we're able to bump cabal-version to 2.4 without grief (i.e., there are released versions of Stack and cabal-install built against Cabal 2.4, and Stackage accepts 2.4-spec files), we can just write extra-source-files = ["dhall/**/*.dhall"] and catch 'em all.

ocharles commented 6 years ago

I'm going to change the CI build to run cabal sdist first. We already do this at work, so it's pretty trivial. PR coming for that.

ocharles commented 6 years ago

https://github.com/dhall-lang/dhall-to-cabal/pull/121 confirms the failure. Merging this to master, then we'll see if #121 is fixed.