Closed quasicomputational closed 5 years ago
quasicomputational
commented
5 years ago Status update: 1.22 has been released, but the fix for the above bug didn't make it, so this is still waiting on a release. There's also another thing I think we're being bitten by (dhall-lang/dhall-haskell#926) which we will need a fix for before upgrading.
ocharles
commented
5 years ago I'm happy to have this merged and released when ready. I'm on holiday until May 15th and won't be able to release until after then. Thanks for the PR!
On Thu, 2 May 2019, 3:52 am quasicomputational, notifications@github.com wrote:
Status update: 1.22 has been released, but the fix for the above bug didn't make it, so this is still waiting on a release. There's also another thing I think we're being bitten by (dhall-lang/dhall-haskell#926 https://github.com/dhall-lang/dhall-haskell/issues/926) which we will need a fix for before upgrading.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dhall-lang/dhall-to-cabal/pull/150#issuecomment-488395433, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAFDDS5F5YVED6LYVOY6ATPTHYITANCNFSM4HI6WIEA .
quasicomputational
commented
5 years ago The 'no-user-facing changes' was nice while it lasted. dhall-haskell HEAD now uses the new nullary constructors pervasively, and it's not worth the candle to try and swim upstream - it's something we'll want to do anyway, so it might as well happen now.
In practice, this is going to mean that we'll skip 1.22 entirely and move on to 1.23 next, since the nullary thing is a breaking change and 1.22 is too broken.
quasicomputational
commented
5 years ago Execution seems a whole lot quicker with the new Dhall version, which is great - still not too quick to be perceptible (like hpack is), but it's no longer so slow that that alone is disqualifying.
With any luck, this PR's ready to go now.
quasicomputational
commented
5 years ago No luck, as I might've predicted - Hydra's unhappy with something, but I don't have much to go on except that adding the base-compat-batteries override triggered it.
ocharles
commented
5 years ago No worries, I'm home Wednesday and can fix it then. Note that there is still an in progress branch that is even faster. We're very close to non-noticeable, I think.
On Sun, 12 May 2019, 4:58 pm quasicomputational, notifications@github.com wrote:
No luck, as I might've predicted - Hydra's unhappy with something, but I don't have much to go on except that adding the base-compat-batteries override triggered it.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dhall-lang/dhall-to-cabal/pull/150#issuecomment-491574039, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAFDDR3T4MLJFT53OF7F63PU7E2FANCNFSM4HI6WIEA .
ocharles
commented
5 years ago Ok, I took a slightly alternative approach of just jailbreaking something earlier. Hydra is happy now, so this is merged. Thanks!
quasicomputational
commented
5 years ago Ah, yeah, that's a good idea - I was trying to manually solve the dep tree, but cutting the knot like this is much simpler. Thanks!
No user-facing changes in this PR, though it might be an idea to use the new streamlined enum-like union syntax where we can.
This doesn't actually work yet on two counts:
I think we're being bitten by a Dhall bug, dhall-lang/dhall-haskell#915, which has left me unable to run the tests.
1.22 hasn't made it onto Hackage anyway, and then the Nix derivations will need to be updated as well.