search

dhall-lang / dhall-to-cabal

Compile Dhall expressions to Cabal files
MIT License
100 stars 19 forks source link

Replace & remove runUnion #164

Closed quasicomputational closed 5 years ago

quasicomputational commented 5 years ago

runUnion stops GHC helping us out with case exhaustivity checking.

In the course of making this PR and getting the benefit of GHC's assistance, I discovered that we weren't handling AArch64 properly, which is an obvious and easily corrected oversight.

It's also made two other incomplete matches visible, but they're slightly less obviously corrected. As this PR isn't making things worse, only revealing problems that already existed, I've elected to leave those as they are.

quasicomputational commented 5 years ago

Oh yeah, this closes #84. I knew I'd talked about this somewhere before.