search

dhall-lang / dhall-to-cabal

Compile Dhall expressions to Cabal files
MIT License
100 stars 19 forks source link

Generate dhall/types with dhall-to-cabal-meta #167

Closed quasicomputational closed 5 years ago

quasicomputational commented 5 years ago

Reviewing the commits in sequence may be productive, though the diff isn't huge anyway (especially discounting the .dhall files).

Theoretically each commit could be landed separately, but I don't think that the refactoring ones are big enough wins in their own right - generating dhall/types, though, should save some toil with every Cabal version upgrade, and that's what I think makes this PR actually worth it.

Once microlens and dhall get released, the inlined versions of transformOf and chunkExprs can go.

ocharles commented 5 years ago

I think this needs a fix for Dhall 1.24

quasicomputational commented 5 years ago

Yeah, legitimate failure. Debugging was slightly hairy (that error message isn't actually pointing particularly near the root cause), but nothing a bit of ScopedTypeVariables trickery didn't clear up.