search

dhall-lang / dhall-to-cabal

Compile Dhall expressions to Cabal files
MIT License
100 stars 19 forks source link

Bump version bounds #188

Open vmchale opened 4 years ago

vmchale commented 4 years ago

This bumps version bounds.

jneira commented 4 years ago

LGTM and there aren't big changes but i would like @quasicomputational or @ocharles take a look.

jneira commented 4 years ago

Well, if nobody disagree i will merge in two days or so

quasicomputational commented 4 years ago

A theoretical issue is that the Dhall Prelude imports are versioned, and that version isn't the same in dhall-haskell 1.26 and 1.27. But the things that are actually imported are identical in those two versions of the standard, so it actually works out OK.

Can you also bump dhall.nix (and the Stackage resolver) to 1.27, so that there's CI coverage for the new version, please? I'm okay with losing 1.26 coverage and that bound potentially bitrotting so long as the latest claimed compatible version is being tested.

jneira commented 4 years ago

@vmchale only left two small changes, have you the time to adress them? if it is not he case i would try to do it