dhall-lang / dhall-to-cabal

Compile Dhall expressions to Cabal files
MIT License
100 stars 19 forks source link

Warning cleaning: unused imports and definitions. #80

Closed quasicomputational closed 6 years ago

ocharles commented 6 years ago

Thanks, I'd been meaning to do this.

quasicomputational commented 6 years ago

Would it be OK if I turned the warning level up? I've found that -Weverything only has a few that need turning off, and the rest are at worst harmless and at best seriously useful.

ocharles commented 6 years ago

Always in favour of more warnings!

On Sun, Jun 3, 2018 at 3:36 PM quasicomputational notifications@github.com wrote:

Would it be OK if I turned the warning level up? I've found that -Weverything only has a few that need turning off, and the rest are at worst harmless and at best seriously useful.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/dhall-lang/dhall-to-cabal/pull/80#issuecomment-394166630, or mute the thread https://github.com/notifications/unsubscribe-auth/AABRjg3nRUATupORe8xgmPrLFviu6BrIks5t4_SCgaJpZM4UYGlH .

quasicomputational commented 6 years ago

OK! I'll go ahead with that on this branch.

ocharles commented 6 years ago

Perfect, thanks!