dhamaso / ufd

Automatically exported from code.google.com/p/ufd
GNU General Public License v2.0
0 stars 0 forks source link

Not working with jQuery 1.6 and higher #55

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. I updated example page to use newer jQuery 
(http://ufd.googlecode.com/svn/tags/0.6/examples/index.html)
2. Replace jquery version to 1.6.2 (I used jquery ui version 1.7.2)
3. Open IE8 and type 'C' to filter Cambodia, Cameroon, Canada - the number of 
results returned is correct, but not proper results are shown as the filter 
result. See attached image.

What is the expected output? Expected output is to filter properly as it does 
when jQuery 1.4.2 is used.

What version of the product are you using? UFD 0.6, jQuery 1.6.2, jQuery UI 
1.7.2, WinXP.

Original issue reported on code.google.com by jaceksko...@gmail.com on 5 Aug 2011 at 7:51

Attachments:

GoogleCodeExporter commented 9 years ago
I forgot to write in the issue title that it's IE where the problem occurs. 
(IE8, and in IETester - IE6, IE7 as well)

Original comment by jaceksko...@gmail.com on 5 Aug 2011 at 7:53

GoogleCodeExporter commented 9 years ago
Hello,

UFD does not work with Jquery 1.6 in Internet Explorer 8. Is there a fix? What 
do I need to change to make this work?

Thanks!
Andrew

Original comment by andrew...@gmail.com on 2 Sep 2011 at 4:37

GoogleCodeExporter commented 9 years ago
Same issue here, only occurs to me in IE8.. IE7 seems fine

Original comment by blue...@bluegod.net on 25 Nov 2011 at 5:42

GoogleCodeExporter commented 9 years ago
Same issue. I think there is a problem with "attr" method because after jquery 
1.6 "attr" isn't working the same as before, there is new method "prop" also.
Before 1.6 $(el).attr('checked') returned true or false, after 1.6 it returns 
'checked' or empty string but $(el).prop('checked') returns true or false.

However i didn't find anything in ufd to suggest at this change, but maybe some 
other problem with "addClass" and "removeClass" (classes are the reason of this 
bug).

Original comment by vernes.s...@gmail.com on 27 Nov 2011 at 5:03

GoogleCodeExporter commented 9 years ago
OK, I found the problem. In IE8 'classAttr' was incorrectly identified as 
'className'.

At line 1234 (ufd 0.6):
classAttr: (($.support.style) ? "class" : "className")

Solution that worked for me was:

classAttr: (($.support.style || ($.browser.msie && $.browser.version=="8.0")) ? 
"class" : "className")

Original comment by vernes.s...@gmail.com on 29 Nov 2011 at 10:54

GoogleCodeExporter commented 9 years ago
Right, I've put a similar fix a few seconds ago! Thanks :)

Original comment by blue...@bluegod.net on 29 Nov 2011 at 11:00

GoogleCodeExporter commented 9 years ago
Thanks guys.

Original comment by jaceksko...@gmail.com on 29 Nov 2011 at 11:02

GoogleCodeExporter commented 9 years ago
I've reported a bug for jquery at http://bugs.jquery.com/ticket/10915.
They say the bug was in versions before 1.6 so a change in UFD is required.

Original comment by vernes.s...@gmail.com on 29 Nov 2011 at 1:00

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
It fixed the normal version. Thanks.
But "min" version is different.

Original comment by buluta...@gmail.com on 13 Jan 2012 at 8:07

GoogleCodeExporter commented 9 years ago
"min" version is similar, line 46:
replace
classAttr:g.support.style?"class":"className"
with
classAttr:(g.support.style||($.browser.msie&&$.browser.version=="8.0"))?"class":
"className"

Original comment by vernes.s...@gmail.com on 13 Jan 2012 at 8:33

GoogleCodeExporter commented 9 years ago
Brilliant, ty

Original comment by ati...@gmail.com on 16 Jan 2012 at 11:50

GoogleCodeExporter commented 9 years ago
Thanks everyone for their community help.  I have fixed this in trunk.

Original comment by thetoolman on 19 May 2012 at 12:19

GoogleCodeExporter commented 9 years ago
Issue 63 has been merged into this issue.

Original comment by thetoolman on 21 May 2012 at 4:11

GoogleCodeExporter commented 9 years ago
Yes  it's worked for jQuery 1.7 also 

classAttr:(g.support.style||($.browser.msie&&$.browser.version=="8.0"))?"class":
"className"

Thanks Folks

Original comment by venkat.a...@gmail.com on 7 Mar 2014 at 9:58