search

dhanikshah / android-todoapp

This is a simple android ToDo List app
0 stars 0 forks source link

[Android Bootcamp] Project 0: Todo - Ready for Review #3

Open dhanikshah opened 8 years ago

dhanikshah commented 8 years ago

My app is complete - please review. /cc @codepathreview @codepath

nesquena commented 8 years ago

Dhanik,

Looks good, this exercise is intended in part to give you an introduction to the general rhythm of this course. The course is entirely project-based with an app being assigned each week and then due the following week. Each project builds on the last to help each engineer learn the practical elements of Android development and best practices as quickly as possible. We also do a code review for each submitted project once the program begins.

The next step is to continue working on extensions to your todo app and to schedule a short 10 minute phone conversation with us. Navigate to today's date and onward from there and choose a 15-minute slot. Let us know if none of those times work.

With regards to extensions to implement, we are looking for developers with an interest in user experience and product development so be sure to focus on additional functional enhancements and/or improving the user interface of the app.

Once you select a slot, can you make sure to include best number to reach you at to the invite? Look forward to chatting soon!

dhanikshah commented 8 years ago

/cc @codepathreview @codepath I have updated the code with SQLite based implementation. Please review. My DB schema contains text field, and id field (primary key) which will be automatically populated (AUTOINCREMENT). For updating todo items, I am querying the DB for id field based on text, passing it to Edit Activity as Intent Extra, and sending it back to Main activity where it will be used to update the corresponding row. Is this the right way to do it? I'm assuming there will be a more efficient way. Appreciate your feedback!

dhanikshah commented 8 years ago

Also working on other extensions/optimizations.

nesquena commented 8 years ago

This is great, nice to see you were able to add a number of useful new optionals. Hope you learned a lot too. Unfortunately the class is full at this point, but we are happy to add you to the waitlist. For those not admitted as participants, we can also offer access to applicants as a remote observer cohort that has access to the materials and is able to work on the projects at their own pace. I'd encourage you to continue working on the pre-work as a learning exercise. Let me know if you'd like to follow along as a remote observer this round.

dhanikshah commented 8 years ago

Added DialogFragment based implementation for Editing Items.

Thanks for the follow-up Nathan. It's been a great learning experience so far. The material is really useful. I would definitely like to work on projects and continue learning as an observer. I am very interested in participating actively - can I apply for a future session?

nesquena commented 8 years ago

I would definitely like to work on projects and continue learning as an observer. I am very interested in participating actively - can I apply for a future session?

Great, I will add you as an observer and send more details soon. Of course, you are free to apply for a future session as well if you feel that will be productive after you give it a try as an observer. As an observer, if you complete the projects, you will be able to learn a tremendous amount.