dhanish265 / pe

0 stars 0 forks source link

Diagram notation used is inconsistent with module notes #11

Open dhanish265 opened 1 year ago

dhanish265 commented 1 year ago

image.png

It should be + and - for public and private methods, rather than red squares and green circles.

soc-pe-bot commented 1 year ago

Team's Response

The PlantUml parameter skinparam Style strictuml' enforces such labelling. Withoutskinparam Style strictuml' the other part of the diagram be different from the note (such as the addition of C for class, E for enum, etc). It is a tradeoff

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: no, it can be done. please look at other teams' diagrams.


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: the issue is not merely cosmetic as it is a violation of the guidelines given by the website.