dhanur / Sunible-Beta

Fresno trial
GNU General Public License v2.0
1 stars 1 forks source link

Add Twitter, Facebook and LinkedIn icons to web page #20

Closed ghost closed 11 years ago

swenson86 commented 11 years ago

Because of the technical requests that Dhanur has for this, I will do my best to implement but may need to defer to Roman for completion.

ghost commented 11 years ago

OK, thanks for the heads up. Let me know how things go.

Give me a call when you can.

Thanks.

John

John Bissell CTO

        Solar Simplified

Cell:     (510) 229-0577
Skype:  john.bissell
Email:   john@sunible.com

55 Harrison Street, 3rd Floor
Oakland, CA 94607

On Tue, Jul 2, 2013 at 4:51 PM, Tanner notifications@github.com wrote:

Because of the technical requests that Dhanur has for this, I will do my best to implement but may need to defer to Roman for completion.

— Reply to this email directly or view it on GitHubhttps://github.com/solarisbetter/beta/issues/20#issuecomment-20387124 .

dhanur commented 11 years ago

Have discussed on email, but I'm putting the specs for Social Media links below again ..

a. Placement: Icons to be alongside the footer links, not in a corner. See illustration linked below. b. Icons can be downloded here - http://cl.ly/310y3H1C1N1v c. Alignment: Needs to be vertical-center-aligned with the footer links, and the whole group (footer links + social icons) need to be horizontal-center-aligned to the page). Here's an illustration - http://grab.by/o7oo d. Links: www.facebook.com/sunible , www.twitter.com/sunible , http://www.linkedin.com/company/sunible

rlytvynchuk commented 11 years ago

Icons added. Assigned to QA

svlasenko commented 11 years ago

I expected when I click on these buttons it will be open in new tab but not in the same. Is it possible to implement in this way? What do you think about it? Should I create a new enhancement?

dhanur commented 11 years ago

Thanks for catching Sveta. No need for separate issue to be logged. Roman, could you please change this to open in new tab?

rlytvynchuk commented 11 years ago

implemented. Assigned to QA

svlasenko commented 11 years ago

Verified in Master and Trunk