dhanushka-94 / npr-android-app

Automatically exported from code.google.com/p/npr-android-app
0 stars 0 forks source link

Hourly News Summary should open a page, not play #47

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
The Hourly News Summary can't be added to a Playlist because it plays 
immediately when tapped, instead of opening a page like other stories that have 
Listen Now, Add to Playlist and Share. It would be nice if Hourly News Summary 
opened a similar page. It would also reduce the harm of accidentally tapping 
this button on the main screen, which results in losing a potentially long 
playlist if you do so accidentally.

Original issue reported on code.google.com by soopah...@gmail.com on 8 Oct 2010 at 11:09

GoogleCodeExporter commented 8 years ago
Will be in 2.0

Original comment by jamie.hu...@gmail.com on 8 Oct 2010 at 11:14

GoogleCodeExporter commented 8 years ago
Excellent. These are both Enhancements, not Defects, but I don't have the 
permissions to set them that way.

Original comment by soopah...@gmail.com on 8 Oct 2010 at 11:42

GoogleCodeExporter commented 8 years ago

Original comment by jpenn...@gmail.com on 12 Oct 2010 at 2:28

GoogleCodeExporter commented 8 years ago
Quick and dirty, mute the commercial break and pick up laptop for 3 minutes, 
let's just see... patch attached.

Original comment by tjack1...@gmail.com on 13 Dec 2010 at 5:13

Attachments:

GoogleCodeExporter commented 8 years ago
Did this ever get code reviewed?

Original comment by jpenn...@gmail.com on 17 Dec 2010 at 8:22

GoogleCodeExporter commented 8 years ago
The idea behind this code is fine, but we don't have any preferences defined 
yet, so it won't do much on its own.

I would like to see this in 2.0. tjack, are you interested in helping out with 
a user preferences activity?

Original comment by mfreder...@google.com on 20 Dec 2010 at 4:39

GoogleCodeExporter commented 8 years ago
!true.  It's !false!  :)

[You would need that preference setting to revert the behavior.]

Original comment by tjack1...@gmail.com on 20 Dec 2010 at 5:03

GoogleCodeExporter commented 8 years ago

Original comment by jeremy.w...@gmail.com on 10 Feb 2011 at 5:20

GoogleCodeExporter commented 8 years ago
Version 2.0 Hourly News Summary now opens as a new page.

However, it does not (yet) support adding the the playlist. This is complicated 
by the fact that hourly news changes, well, hourly. So if we add the hourly 
news podcast to the playlist there's a possibility that the new stories will be 
out of date by the time we get there which isn't the expected UX. To resolve 
that we just need to create a special case in the Playback Service so that it 
knows what Hourly News is and knows how to resolve it. To-date the player has 
never known about the API, so we're increasing coupling when we do this.

Original comment by jeremy.w...@gmail.com on 23 Mar 2011 at 4:01

GoogleCodeExporter commented 8 years ago
I actually think the expected behavior is, whatever was added to the playlist 
is what will play. So if I added it 2 weeks ago, I'm going to get the hourly 
news for 2 weeks ago.

I think the only missing piece is to ensure that the title added to the 
playlist is clear about which hour that hourly news is from.

Original comment by soopah...@gmail.com on 23 Mar 2011 at 4:10

GoogleCodeExporter commented 8 years ago
For now, this item is being closed. Let's open a different issue if we decided 
to move in a different direction for the UX of the newscast.

Original comment by jpenn...@gmail.com on 16 Nov 2011 at 5:09