Visibility check on comments should only check parent

dharamgollapudi / jaikuengine

Automatically exported from code.google.com/p/jaikuengine

Apache License 2.0

0 stars 0 forks source link

Visibility check on comments should only check parent #56

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Currently we check the comment's stream's visibility to the viewer - that's
wrong, as comments inherit visibility from the post.

Will need to continue to check that the stream exists though.

Original issue reported on code.google.com by mika.rae...@gmail.com on 19 Mar 2009 at 2:20

GoogleCodeExporter commented 9 years ago

This: http://yerga.jaiku.com/presence/8c8a388afff247bf81022a57a28cb14b seems to 
be
suffering from this bug

Original comment by adewale on 21 Mar 2009 at 9:27

GoogleCodeExporter commented 9 years ago

I'm not sure the below is a consequence of this issue or not but I'm assuming 
it is.

Comments on private posts seem to be displayed through the IM interface on the 
basis of having access to the 
commenters' stream. These comments are not visible in ones overview though.

As stated by Mika, comments should inherit visibility from the post.

Original comment by jonasnoc...@gmail.com on 30 Mar 2009 at 9:06

GoogleCodeExporter commented 9 years ago

Original comment by andyster on 22 Apr 2009 at 11:01

Changed state: Accepted
Added labels: Priority-High, privacy
Removed labels: Priority-Medium

GoogleCodeExporter commented 9 years ago

Marking this as a duplicate of issue 120. This patch: 
http://rietku.appspot.com/24001
should fix both issues.

Original comment by adewale on 22 Jul 2009 at 4:45

Changed state: Duplicate