search

dharanad / Popular-Movies

An app that let users to discover the most popular movies playing.
3 stars 9 forks source link

Add screenshots and update contribution steps #7

Open alouanemed opened 7 years ago

rajtheinnovator commented 7 years ago

@dharan1011 okay. Let me do that now. Will take some minutes, 30 min at max, I hope.

alouanemed commented 7 years ago

@dharan1011 sure, do we wait until @rajtheinnovator's new UI got merged and then we update the screenshot?

rajtheinnovator commented 7 years ago

@alouanemed I think we can go on to update the screenshot as the fact is that our UI might change as we progress though it. So, later on all we might need to change is changing the image Url.

dharanad commented 7 years ago

@rajtheinnovator @alouanemed This PR has conflicts. I am closing it now make a new PR with updated UI.

alouanemed commented 7 years ago

@dharan1011 no need to close the PR. I will solve the conflicts on this one .

rajtheinnovator commented 7 years ago

@dharan1011 please let @alouanemed fix the conflict. And meanwhile I'm making another PR. @dharan1011 We're almost close to the target we started with I think.

dharanad commented 7 years ago

@rajtheinnovator Yeah We are almost there.

rajtheinnovator commented 7 years ago

@dharan1011 can you accept my last PR?

dharanad commented 7 years ago

@alouanemed Actually right now I amn't using workstation, once I get home I will be checking and merging.

rajtheinnovator commented 7 years ago

Sure thing @dharan1011 . No issues. Have fun :+1:

alouanemed commented 6 years ago

@dharan1011 can you resolve the conflicts from the UI ?

dharanad commented 6 years ago

No it still have conflicts.