dhardy / pippin

a distributed-merge capable database for many small objects
ISC License
78 stars 4 forks source link

Partition numbers #26

Closed dhardy closed 8 years ago

dhardy commented 8 years ago

Currently,

This is historical: it was not planned that the numbers would be found in the file names, and single-partition usage was implemented before multi-partition functionality. This could still be changed. But should it?

Proposals:

  1. do nothing
  2. make the number available from PartitionIO and just verify when loading; in this case Partition::open() doesn't need the number passed any more
dhardy commented 8 years ago

Closing for now: PartitionIO optionally stores the PartId, Partition requires a PartId on creation.

Possibly Partition should allow creation without the PartId and discover later, but having it like this before was a nuisance.