search

dhardy / rand

http://doc.rust-lang.org/rand
Other
2 stars 2 forks source link

Drop support for PNaCL #19

Closed pitdicker closed 7 years ago

pitdicker commented 7 years ago

Now that rustc and Google now longer support it, it seems we can remove the code from OsRng. See https://github.com/rust-lang/rust/pull/45041 and https://github.com/rust-lang/rust/issues/42420

dhardy commented 7 years ago

Be nice to remove that, but issue linked (#42420) mentions that only PNaCl is deprecated, not Google NaCl.

pitdicker commented 7 years ago

Hmmm, yes. It is a bit messy

From https://github.com/rust-lang/rust/issues/42420#issuecomment-335308746:

I think NaCl has gotten some use outside the browser, so I could imagine a case for still supporting NaCl in Rust. It's probably only worth doing if there are current users of it though.

I read that as: the primary use case for target_os = "nacl" is to support running Rust code in browsers. That is not available anymore. Maybe there is someone be uses Rust together with the NaCl sandboxing technology. Probably not, but we don't know.

Personally, I would rather remove it. If there is really somebody using it, say sorry and add it back. Instead of modifying it now to add proper error handling, and going through the trouble to somehow test it.