search

dharmaprotocol / excluded-uni-airdrop-users

28 stars 48 forks source link

Add excluded Dexag users #7

Closed nedodn closed 3 years ago

nedodn commented 3 years ago

So I noticed the tests were failing locally, but all of the five failing addresses were addresses that had tried to submit a transaction involving Uniswap but failed, for example: https://etherscan.io/tx/0x94cbcdade623fbfb2a1f05d220cec3835dad4e5078316469d2097002decf20c0

If you check the input data in the exchanges variable, you can see it attempted to call a Uniswap exchange. Would this be a valid transaction and if so, what is the issue causing the tests to fail?

I think it may be possible the transactions failed before getting a chance to call the uniswap exchange, but not 100% sure.

0age commented 3 years ago

Hey @nedodn — failed transactions should be picked up, but only if the attempt actually made it through to calling uniswap and failing there. This transaction looks like it ran out of gas before that ever happened, so I'd say these should be filtered out!

nedodn commented 3 years ago

@0age gotcha, thanks for the quick answer! I'll double check but I believe all the failing addresses were in a similar spot, I can just go in and filter out those from our list.