search

dharmit / tinyutils

Small utils to print Linux system info in a prettier format
MIT License
4 stars 8 forks source link

Added Network Class #20

Closed vatsalparekh closed 7 years ago

vatsalparekh commented 9 years ago

Takes care of #8 and #1

dharmit commented 9 years ago

I don't see anything getting printed when I do python3 tinyutils.py. Can you elaborate what has been done here?

vatsalparekh commented 9 years ago

I added this network file here, which uses other files to parse data. I felt like network file should return the data when its called, so in our context the main tinyutils will take the specific -n switch and than network file will return data to it.

dharmit commented 9 years ago

I added this network file here, which uses other files to parse data.

network.py file doesn't have any documentation whatsoever. So, it doesn't ring bells as to what it is doing. Same for command.py and parse.py.

I am sure your intentions have been good. But without proper documentation, it's difficult to understand what you're trying to do.

I recommend adding comments using Python's docstring specification.

so in our context the main tinyutils will take the specific -n switch and than network file will return data to it.

And does it do so yet? I mean by this commit. Not any future commits/PR.