Closed santosh898 closed 5 years ago
Hi @santosh898 , thanks for your contribution! Please give us a bit to think about this.
@dharness Is this a feature we want, and if so, an implementation consistent with others? I'm less versed in this side of the project. :)
@santosh898 thanks for the contribution! I like this feature, but I feel like we should explore other ways to add message types like this. Given that this is going to be bundled with peoples above-the-fold-content we want to keep it small, and not everyone may need something specific like ImageZoom. We also don't want to let our dependencies snowball beneath our feet so let's be prudent.
Suppose instead we allowed users to add custom message types and either: a) had a clean api for adding custom message types b) supported extensions so people can make, publish, and install message types like this c) both of those things
I'm going to close this PR because I think we should favour a different approach - but it's open for discussion.
Used
react-medium-image-zoom
for interactive image viewing. Updated all packages to their latest versions.