search

dharness / react-chat-window

Intercom-style live chat window written in react
The Unlicense
671 stars 250 forks source link

Add typing indicator #127

Closed kaxi1993 closed 5 years ago

kaxi1993 commented 5 years ago
Screen Shot 2019-07-19 at 15 19 38
heatherbooker commented 5 years ago

Hey @kaxi1993, thanks for the PR! I haven't had a chance to check it out yet, but can you make sure documentation like the readme is updated too?

kaxi1993 commented 5 years ago

Hi @heatherbooker, sure I'll update docs

kaxi1993 commented 5 years ago

Code structure (new files, indentation) looks great and so do the little jumping dots!

Can the demo be made to work with the indicator? I think that would help

  1. users understand how to use it
  2. me understand whether it works ;)

Right now, I'm a bit confused as to the difference between disabling the typing indicator entirely versus it being an appropriate moment to show it (ie, other user is actually typing).

My other comments may become irrelevant depending on the answer to the above :)

@heatherbooker sure I'll add usage of typing in demo and will update you soon

kaxi1993 commented 5 years ago

Hey @heatherbooker, I updated demo. When you start typing in textarea, typing indicator appears in chatbot window.

I'm going to create chatbot on my website and I want to use react-chat-window. There are times when the server takes 4-5 seconds to respond to user messages, I think this indicator will be helpful in this situations.

kaxi1993 commented 5 years ago

Hi @dharness, thanks for your feedback. I fixed all of them, please review again and let me know if there is any problem.