dharness / react-chat-window

Intercom-style live chat window written in react
The Unlicense
677 stars 252 forks source link

Update react version to resolve UNMET PEER DEPENDENCEY warnings upon install #70

Open Combinations opened 6 years ago

Combinations commented 6 years ago

Using react 16.x and react-dom 16.x

running: npm install react-chat-window --save

├── UNMET PEER DEPENDENCY react@16.3.0
└─┬ react-chat-window@1.0.8
  ├─┬ emoji-js@3.2.2
  │ └── emoji-datasource@3.0.0
  ├─┬ gh-pages@1.1.0
  │ ├── base64url@2.0.0
  │ ├── commander@2.11.0
  │ ├─┬ fs-extra@4.0.3
  │ │ └── jsonfile@4.0.0
  │ └── globby@6.1.0
  ├── prop-types@15.5.10
  ├── UNMET PEER DEPENDENCY react@^0.14.0 || ^15.0.0
  ├── UNMET PEER DEPENDENCY react-dom@^0.14.0 || ^15.0.0
  ├─┬ react-highlight.js@1.0.5
  │ └── highlight.js@9.12.0
  └─┬ socket.io-client@2.0.3
    ├── backo2@1.0.2
    ├── base64-arraybuffer@0.1.5
    ├── component-bind@1.0.0
    ├─┬ engine.io-client@3.1.6
    │ ├── component-inherit@0.0.3
    │ ├── debug@3.1.0
    │ ├─┬ engine.io-parser@2.1.2
    │ │ ├── after@0.8.2
    │ │ ├── arraybuffer.slice@0.0.7
    │ │ └── blob@0.0.4
    │ ├─┬ ws@3.3.3
    │ │ ├── async-limiter@1.0.0
    │ │ └── ultron@1.1.1
    │ ├── xmlhttprequest-ssl@1.5.5
    │ └── yeast@0.1.2
    ├── has-cors@1.1.0
    ├── object-component@0.0.3
    ├─┬ parseqs@0.0.5
    │ └─┬ better-assert@1.0.2
    │   └── callsite@1.0.0
    ├── parseuri@0.0.5
    ├─┬ socket.io-parser@3.1.3
    │ ├── debug@3.1.0
    │ ├─┬ has-binary2@1.0.3
    │ │ └── isarray@2.0.1
    │ └── isarray@2.0.1
    └── to-array@0.1.4

npm WARN react-chat-window@1.0.8 requires a peer of react@15.x but none was installed.
npm WARN react-highlight.js@1.0.5 requires a peer of react@^0.14.0 || ^15.0.0 but none was installed.
npm WARN react-highlight.js@1.0.5 requires a peer of react-dom@^0.14.0 || ^15.0.0 but none was installed.
dharness commented 6 years ago

Looks like react 16.x isn't supported :/ -- PR is welcome

heatherbooker commented 6 years ago

Is there a way for react-chat-window to support 15.x and 16.x as peer dependency options? Or no dice?

dharness commented 6 years ago

@heatherbooker probably some if statements combined with React.version; in the worst case, and some clever averaging in the best case. But I'd say yes

AppLoidx commented 5 years ago

I got this WARNs with react 16.9.0, but react-chat-window still works