search

dharple / detox

Tames problematic filenames
BSD 3-Clause "New" or "Revised" License
332 stars 19 forks source link

Confirm macOS support #35

Closed dharple closed 3 years ago

dharple commented 3 years ago

Add a Travis test for macOS to confirm builds there.

dharple commented 3 years ago

Getting script failures (possibly due to BSD vs Linux) on macOS. I thought at first it was a bash problem, but the modern version of macOS supports installing a modern copy of bash via brew.

https://travis-ci.com/github/dharple/detox/jobs/484837371#L21

bash version
GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin19)

https://travis-ci.com/github/dharple/detox/jobs/484837371#L426

Installing bash formula. It is not currently installed.
==> Downloading https://homebrew.bintray.com/bottles/bash-5.1.4.catalina.bottle.
==> Downloading from https://d29vzk4ow07wi7.cloudfront.net/2195ea39cf6607ec440ad
######################################################################## 100.0%
==> Pouring bash-5.1.4.catalina.bottle.tar.gz
🍺  /usr/local/Cellar/bash/5.1.4: 157 files, 10.9MB
Installing bash

https://travis-ci.com/github/dharple/detox/jobs/484837371#L540

$ bash --version
GNU bash, version 5.1.4(1)-release (x86_64-apple-darwin19.6.0)
Copyright (C) 2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
The command "bash --version" exited with 0.

But, maybe it's a path issue....

dharple commented 3 years ago

Apparently I've burned through 66% of my Travis credits already. I noticed when one of my builds stopped working, and I went to investigate.

dharple commented 3 years ago

make check still fails on macOS, because bash and sed are both old. I'll attempt to use the homebrew versions of these in the future. Maybe using env bash instead of calling /bin/bash directly from the hashbang? I need a box to test this on.