dharple / detox

Tames problematic filenames
BSD 3-Clause "New" or "Revised" License
332 stars 19 forks source link

Compiling under CircleCI is broken #91

Closed dharple closed 2 years ago

dharple commented 2 years ago

During the make stage of compilation on CircleCI, I get the following error:

#!/bin/bash --login -eo pipefail
make

Making all in src
/Applications/Xcode-12.5.1.app/Contents/Developer/usr/bin/make  all-am
gcc -DHAVE_CONFIG_H  -I.    -DDATADIR=\"/usr/local/share\" -DSYSCONFDIR=\"/usr/local/etc\" -DYY_NO_INPUT -DYY_NO_UNPUT -D_FORTIFY_SOURCE=2 -Wall -Werror -g -O2 -fstack-clash-protection -fstack-protector-strong -MT config_file_yacc.o -MD -MP -MF .deps/config_file_yacc.Tpo -c -o config_file_yacc.o config_file_yacc.c
clang: error: argument unused during compilation: '-fstack-clash-protection' [-Werror,-Wunused-command-line-argument]
make[2]: *** [config_file_yacc.o] Error 1
make[1]: *** [all] Error 2
make: *** [all-recursive] Error 1

Exited with code exit status 2

CircleCI received exit code 2
dharple commented 2 years ago

Upon further investigation, it looks like the custom autoconf macro, AC_CHECK_CFLAG, needs to add -Werror to the test compilation command; the flag in question is failing, but it only generates a warning during the test, not an error, so configure adds the flag to the list of CFLAGS.