dhasegan / connect.academy

Educational platform
www.connect.academy
MIT License
2 stars 0 forks source link

Closed registration #39

Closed dhasegan closed 10 years ago

dhasegan commented 10 years ago

I set up an account and registered for a course by the deadline. I approved the account and everything worked. after some time I entered again and now I cannot see the stuff that I could see before. (homework and documents)

This is because when I check the registration_status in the context_processor for the course_page_context, it returns me "CLOSED" instead of "REGISTERED".

Though, if I go to my courses it tell me that I am registered for the course.

dont know what is the problem exactly but you should put the code to figure out if the user is registered in the models as a function.

tpllaha commented 10 years ago

hmm interesting. I might have an idea what's happening. I'll look into that and close this issue tonight or tomorrow morning if I can't find it immediately.

tpllaha commented 10 years ago

oohh.. I see... That happens because I meant to use registration_status only to get check if the student can register for the course at this point in time, not to always check if they're registered for the course.

How do you think I should solve this? Should I add another field for this purpose? Or just make it REGISTERED when the student is registered, even if registration is not open? (This would make the little green "Registered" boxes always appear in the course block, even when course registration is not open, but that's probably not a bad idea anyways... Because it allows them to easily distinguish their courses in the homepage)

dhasegan commented 10 years ago

I think you are mingling the course_registration status in general with the user registration for a course status. Maybe it would be more clear to split them into 2

tpllaha commented 10 years ago

Ok, then here's a suggestion:

registration_open: True or False (if course registration is open or not) registration_status (for the particular students): OPEN, PENDING, REGISTERED, or IS_NOT_ALLOWED (for students who are not in the same university)

How does this sound?

dhasegan commented 10 years ago

sounds good.

Does it work for professors registering for courses? I think it does.

tpllaha commented 10 years ago

Well I can make that a case of NOT_ALLOWED, since I'll have to rewrite it anyways

tpllaha commented 10 years ago

or do you mean that we should allow them?

tpllaha commented 10 years ago

ok let's move this discussion to hipchat