dhatim / dropwizard-sentry

Dropwizard integration for error logging to Sentry.
Apache License 2.0
9 stars 9 forks source link

Config doesnt work in version 2.0.29 #85

Open abintrd opened 1 year ago

abintrd commented 1 year ago

Following configuration doesn't work after upgrading the package from 2.0.12-1 to 2.0.29

    - type: sentry
      stacktraceAppPackages:
        - com.tradeshift
      threshold: ERROR
      dsn: https://key@sentry.io/1228780
      mdcTags: ['actor', 'tenant']
      environment: dev
      release: somerelease

throws this error

Caused by: com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Failed on call to `getDeclaredMethods()` on class `org.dhatim.dropwizard.sentry.logging.SentryAppenderFactory`, problem: (java.lang.NoClassDefFoundError) io/sentry/SentryOptions
 at [Source: UNKNOWN; byte offset: #UNKNOWN] (through reference chain: com.tradeshift.ada.coding.AdaCodingConfiguration["logging"]->io.dropwizard.logging.DefaultLoggingFactory["appenders"]->java.util.ArrayList[1])
tresni commented 10 months ago

Looks like this changed with https://github.com/dhatim/dropwizard-sentry/commit/c907978a6459f44fb1676491e2222f980281599d and you should use inAppIncludes as a direct replacement for stacktraceAppPackages. Not sure what else is going on yet