search

dhatim / fastexcel

Generate and read big Excel files quickly
Other
672 stars 122 forks source link

ReadableWorkbook constructor with File and ReadingOptions #191

Closed AstrorEnales closed 2 years ago

AstrorEnales commented 2 years ago

First, thanks for this project! It solved the memory and speed issues i had with apache poi.

As the InputStream constructor copies all bytes to memory, i would be happy to use the File constructor of ReadableWorkbook, however, i also need the ReadingOptions to read cell data formats. So it would be wonderful, if you could add a constructor overload with these two parameters: public ReadableWorkbook(File inputFile, ReadingOptions readingOptions) throws IOException { this(OPCPackage.open(inputFile, readingOptions.isWithCellFormat()), readingOptions); }

As it's only three lines of code, i refrained from creating a whole fork and pull request.

ochedru commented 2 years ago

Thank you for your feedback. I'll do the PR.