search

dhatim / fastexcel

Generate and read big Excel files quickly
Other
651 stars 118 forks source link

Update test case for issue #244 #247

Closed meiMingle closed 1 year ago

meiMingle commented 1 year ago

Update test case for issue #244

ochedru commented 1 year ago

Thank your for your PR! I was surprised the build does not fail with the hardcoded path D://protectedTest.xlsx and the implicit dependency of fastexcelReadProtectTest on fastexcelWriteProtectTest to read the generated workbook. Actually, there is another issue that prevent all tests from being executed... I am going to investigate this.

ochedru commented 1 year ago

FYI tests restored in #248

meiMingle commented 1 year ago

Thank your for your PR! I was surprised the build does not fail with the hardcoded path D://protectedTest.xlsx and the implicit dependency of fastexcelReadProtectTest on fastexcelWriteProtectTest to read the generated workbook. Actually, there is another issue that prevent all tests from being executed... I am going to investigate this.

You are right, I will refactor it