search

dhatim / fastexcel

Generate and read big Excel files quickly
Other
651 stars 118 forks source link

Cleanup Maven #276

Open zorglube opened 1 year ago

zorglube commented 1 year ago

I removed some maven variable and updated version numbers.

I purpose to use mvn versions pluging or maven release plugin in order to set dependencies version or release number and building.

ochedru commented 1 year ago

Thank you for your PR. Actually, we got some inspiration from this article and the goal was to have an efficient CI-compatible release process, not to have an "up to date" pom.xml in git.

zorglube commented 1 year ago

Thank you for your PR. Actually, we got some inspiration from this article and the goal was to have an efficient CI-compatible release process, not to have an "up to date" pom.xml in git.

I understand. I'm pretty sure it's possible have an intermediate solution that satify your requierments and the consistency into the POM.

Should I continue to work on that, or should I drop the idea ?

ochedru commented 1 year ago

In my opinion, this is not a critical issue. It also depends on how much time you can spend on this topic. Maybe things changed since 2016 (c.f. the date of the last article from the series)...

zorglube commented 1 year ago

In my opinion, this is not a critical issue. It also depends on how much time you can spend on this topic. Maybe things changed since 2016 (c.f. the date of the last article from the series)...

Okay, I'll have a look but not spend a lot of time and brain on it.

zorglube commented 1 year ago

It seems that GitHub has a packager Maven Release action https://github.com/qcastel/github-actions-maven-release