search

dhatim / fastexcel

Generate and read big Excel files quickly
Other
644 stars 116 forks source link

Build with Java 11 #393

Closed ochedru closed 4 months ago

hrstoyanov commented 4 months ago

@ochedru Thanks for doing this! The code change looks good, one question though: You have org.dhatim.fastexcel.reader but then I see org.dhatim.fastexcel instead of org.dhatim.fastexcel.writer ?

Btw, if you later decide to implement a complete modularization, I will help.

When do you plan on deploying a new version with this change in?

ochedru commented 4 months ago

@hrstoyanov The writer module artifact id is actually org.dhatim.fastexcel (originally, fastexcel was built only to write Excel files). However, I am not sure if this has to match Automatic-Module-Name? As soon as the PR is ok for you, I merge it and release version 0.17.0.

hrstoyanov commented 4 months ago

The module names don't matter that much, go ahead and release the new version, please