search

dhatim / fastexcel

Generate and read big Excel files quickly
Other
643 stars 116 forks source link

Add full JPMS modules on Java8 #395

Closed charphi closed 2 months ago

charphi commented 4 months ago

See https://github.com/dhatim/fastexcel/issues/388

hrstoyanov commented 4 months ago

Thanks @charphi . Why not make them transitive?

module org.dhatim.fastexcel {
    requires transitive opczip;

    exports org.dhatim.fastexcel;
}

module org.dhatim.fastexcel.reader {
    requires transitive java.xml;
    requires transitive org.apache.commons.compress;
    requires transitive com.fasterxml.aalto;

    exports org.dhatim.fastexcel.reader;
}
charphi commented 4 months ago

I'm not sure if transitive is a good idea since it forces the fastexcel dependencies on modules using fastexcel. A better approach is to hide these dependencies so they can be replaced afterwards if needed.

meiMingle commented 2 months ago

@ochedru I vote for this PR. It is very important to restore the compatibility of java8. I have to say that java8 still occupies a large share.