compatibility test: write with fastexcel, read with apache poi

dhatim / fastexcel

Generate and read big Excel files quickly

Other

684 stars 122 forks source link

compatibility test: write with fastexcel, read with apache poi #58

Closed rzymek closed 5 years ago

ochedru commented 5 years ago

Thank you for your PR! There are actually some compatibility tests in Correctness.java where we generate a workbook with fastexcel and read it with POI after. Maybe this is an opportunity to refactor tests?

rzymek commented 5 years ago

Yeah, I might have missed it. Correctness.java is rather big.

ochedru commented 5 years ago

It looks like lot of tests from Correctness could be moved to PoiCompatibility for clarity.

ochedru commented 5 years ago

Do you agree to close this PR for now?

rzymek commented 5 years ago

Sure

On Mon, 11 Feb 2019, 19:13 Olivier Chédru, notifications@github.com wrote:

Do you agree to close this PR for now?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dhatim/fastexcel/pull/58#issuecomment-462433940, or mute the thread https://github.com/notifications/unsubscribe-auth/ADWib9xK7LvYxLfM-3cXeaAhZLNKLBzmks5vMbLWgaJpZM4aUsgV .