search

dhaus67 / useq

analyzer for %q formatting
Apache License 2.0
1 stars 0 forks source link

useq linter vs gocritic status #3

Open ccoVeille opened 1 week ago

ccoVeille commented 1 week ago

I discovered your linter when you opened

https://github.com/golangci/golangci-lint/pull/5033

The code review led to decline your linter because it was close to gocritic one

This rule already exists inside golangci-lint: gocritic (sprintfQuotedString)

But, as you spotted here, your linter supersedes the gocritic one.

thanks for pointing out the duplicate, however this only covers fmt.Sprintf calls while this linter would cover essentially any printf like methods. Should this rather be extended in gocritic then if we don't want to add useq in golangci-lint?

I agree with @bobsimon

Should this rather be extended in gocritic then if we don't want to add useq in golangci-lint?

Yes, filing a PR to improve the feature in gocritic would be the best option here!

So I'm opening an issue in your repository for asking for a follow-up

ccoVeille commented 5 days ago

@dhaus67 ?