dhavalpzala / multi-hashmap

MIT License
3 stars 2 forks source link

remove method #7

Open Kawabaumga opened 6 years ago

Kawabaumga commented 6 years ago

Hi,

In the remove method, you are comparing the record's size and the dimension's size before remove the record if sizes match.

I think this is a problem if you use a multi-hashmap with mapped dimensions and non-mapped dimensions. In fact, records returned by the find method will contain mapped dimensions data AND non-mapped dimensions data whilst your dimensions.length only take in account mapped dimension.

Can you tell me why we need to have this check before removing the record please?

Yours sincerely, Julien BAUMGARTEN