search

dhbaird / easywsclient

A short and sweet WebSocket client for C++
MIT License
741 stars 205 forks source link

added ssl support, fixed a bug in receiving continuation frames. #29

Closed ahtsiu closed 10 years ago

ahtsiu commented 10 years ago

simply wrapped in openSSL, did not handle any advanced key/cert related stuff.

dhbaird commented 10 years ago

Thanks a lot, ahtsiu. I would like to integrate SSL in a way that doesn't make SSL a mandatory dependency. There are at least two ways to achieve this: (1) use #define/#if flags, or (2) inject the SSL strategy as an argument to the constructor (see The Clean Code Talks - Don't Look For Things!). I have a preference for method 2 (injection), but I would gladly accept your patch if you can make SSL support optional either way. Can you make a new pull request? Thanks!

dhbaird commented 10 years ago

Btw, if you prefer, I can rework your patch for you as per above. If you want to do it, great, but if you don't have time, I can fix it up. Just let me know. Thanks!

dhbaird commented 10 years ago

Hi there, any update on this?

ahtsiu commented 10 years ago

Hi dhbaird, sorry for late reply. I understand that adding ssl support makes this lib more complicated, which is not necessary, especially for those who dont need ssl at all, and I agree that we'd better keep this lib just light weight and sweet. I am not a ssl expert and not planning to go any further about it, I made the modification just because I wanted to simply connect to a wss server. I'll close this pullrequest, you idea seems more elegant. BTW, I also simply fixd the bug in receiving continuation frames, should I open a new pullrequest?

dhbaird commented 10 years ago

No worries! Yes, please open a new pull request for continuation frames. As for the SSL, I do like what you did, and I'll try to hand merge it in on the command line and make SSL optional (as per above). Github will give you credit for the original patch, and my fix will just look like a patch on top of that. Does that sound good?