Pitch shifting is not done

[AndreyBocharnikov]

Hello and thank you for your amazing work, especially for comments like this and this, they are super helpful. I have a question about apply_formant_and_pitch_shift function from here, after computingnewMedian here, its value is not used anywhere, and Parselmouth function "Shift frequencies" (something like call(pitch_tier, "Shift frequencies", sound.xmin, sound.xmax, -30, "Hertz")) is not being called either. Am I missing something?

[dhchoi99]

Applying pitch shifting is done with change_gender at apply_formant_and_pitch_shift. https://github.com/dhchoi99/NANSY/blob/fcfb646ed64a6612e2e7828a750ade89861fa23b/datasets/functional.py#L134-L137

I'm not that familiar with how parselmouth or praat works with its own change_gender functionality, but it is reasonable to think that it could also handle pitch since it has new pitch median argument.