search

dhcwg / rfc8415bis

RFC8415bis
The Unlicense
0 stars 1 forks source link

Updated UDP port text and removed IA Addr requirement to be IA_NA. #11

Closed twintersunh closed 3 weeks ago

bevolz commented 4 months ago

Hi Tim:In general, looks great. However, the new section for IA Address Option:

IA Address Option The IA Address option is used to specify an address associated with an IA_NA. The IAaddr‑options field encapsulates those options that are specific to this address. The format of the IA Address option is:Is not necessarily much better as it still ties this option to IA_NA which it isn’t in a Leasequrery nor in the address notification work.I wonder whether the following is better:     
     IA Address Option      The IA Address option is used to specify an address.      In this document it is only used encapsulated within an IA_NA.      The IAaddr options field encapsulates those options that are      specific to this address.      The format of the IA Address option is:Or something like that. We could reference that it is used elsewhere in Leasequery (RFC 5007) and the new address notification RFC , but not sure that is necessary?- Bernie (from iPad)On Jul 5, 2024, at 12:26 PM, Timothy Winters @.***> wrote:

You can view, comment on, or merge this pull request online at:   https://github.com/dhcwg/rfc8415bis/pull/11

Commit Summary

4150a23 Updated UDP port text and removed IA Addr requirement to be IA_NA.

File Changes (1 file)

M
draft-ietf-dhc-rfc8415bis.xml
(15)

Patch Links:

https://github.com/dhcwg/rfc8415bis/pull/11.patch https://github.com/dhcwg/rfc8415bis/pull/11.diff

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: @.***>

bevolz commented 4 months ago

Oh, and thanks for working on this!

If and when we’re ready to publish, I’m happy to do a final review comparing current published with new.

mcr commented 4 months ago

go ahead. Not sure how these other commits wound up in your branch, but whatever.

tomaszmrugalski commented 4 months ago

I've reviewed those changes and they look good. I particularly like the port clarification.

tomaszmrugalski commented 4 months ago

And thanks for moving forward with this!

twintersunh commented 4 months ago

I reverted my bad commit, my apologies for the noise. I made changes based on Bernie's feedback.

bevolz commented 4 months ago

Hi Tim:Thanks …        The IA Address option is used to specify an address.         In this document it is only specified to be encapsulated within an         IA_NA.  DHCPv6 Leasequery specifies         using of the IA Address Option. The IAaddr‑options field encapsulates those         options that arespecific to this address.

However, a space is missing in “arespecific” and it might be better to say:

        DHCPv6 Leasequery makes         use of the IA Address Option without encapsulating it in IA_NA.- Bernie (from iPad)On Jul 8, 2024, at 2:40 PM, Timothy Winters @.***> wrote: I reverted my bad commit, my apologies for the noise. I made changes based on Bernie's feedback.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: @.***>

twintersunh commented 4 months ago

Thanks for the quick review Bernie. Made the changes.