search

dhedge / frontend-widget

Widget interface for organization branded dHEDGE pools
1 stars 4 forks source link

Mashrukh - DHedge Frontend Widget #2

Open mushroomgenie opened 2 years ago

edsonayllon commented 2 years ago

Please delete the React images that come by default with the React app template. If you need the dHEDGE logo, let me know. I can post it here

edsonayllon commented 2 years ago

@mushroomgenie this PR still contains React logos

mushroomgenie commented 2 years ago

@edsonayllon removed from the public folder

edsonayllon commented 2 years ago

@edsonayllon removed from the public folder

You can use these images to replace them logo192 logo512

edsonayllon commented 2 years ago

@mushroomgenie How was this tested? There's a connect wallet button in the app that doesn't do anything

edsonayllon commented 2 years ago

@mushroomgenie The frontend team looked at this PR. They reported the following:

We created this bounty as our capacity was focused on the previous release. Now with that release deployed, our frontend team can take this task on. It seems we underestimated the amount of effort this project requires when creating the bounty.

We will be using a different approach to deal with this use case than an NPM package. Though, we want to give you a partial payout for your work and effort

mushroomgenie commented 2 years ago

@edsonayllon I used the axios for graphql because I was calling another API endpoint(dehedge graphql API) for it and the urql is fetching from the optimism subgraph.