Write automated tests for pyfacebook.

dhellmann / google-highly-open-participation-psf

Automatically exported from code.google.com/p/google-highly-open-participation-psf

0 stars 0 forks source link

Write automated tests for pyfacebook. #154

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Write automated tests using unittest, nose, or py.test, for pyfacebook:

      http://code.google.com/p/pyfacebook/

Write the tests to achieve > 70% code coverage (see MeasuringCodeCoverage).

Completion:

Attach an 'svn diff' (context diff) against the latest pydigg source to this
task and send it to the author of pydigg.

Relevant wiki pages:

 - HowToTest
 - RecordingTestCoverage

Task duration: please complete this task within 5 days (120 hours) of claiming 
it.

Original issue reported on code.google.com by the.good...@gmail.com on 26 Nov 2007 at 6:28

GoogleCodeExporter commented 9 years ago

Original comment by the.good...@gmail.com on 27 Nov 2007 at 8:39

Added labels: test
Removed labels: tests

GoogleCodeExporter commented 9 years ago

I claim this task

Original comment by molly.mc...@gmail.com on 29 Nov 2007 at 12:24

GoogleCodeExporter commented 9 years ago

Original comment by doug.hel...@gmail.com on 29 Nov 2007 at 12:47

Changed state: Claimed
Added labels: ClaimedBy-molly.mccreary

GoogleCodeExporter commented 9 years ago

I think I will need an extension for this task. It has turned out to be harder 
than I
thought, but I currently have 43% coverage as reported by coverage.py and I have
found 1 error in the source. I have a basketball game and have to cheer for 
another
game after that, so I won't be able to work on it tomorrow evening.

Original comment by molly.mc...@gmail.com on 3 Dec 2007 at 3:38

GoogleCodeExporter commented 9 years ago

Hi Molly!  No problem -- but could you upload/attach the changes you've made so 
far?
 Then we can comment on them and get some feedback to you.

Thanks for letting us know about the delay.

And good luck in the games!

Original comment by the.good...@gmail.com on 3 Dec 2007 at 5:57

GoogleCodeExporter commented 9 years ago

I'm at 59% coverage (not counting the __name__ == __main__). I used the 
minimock.py
module to mock the urllib2.

Original comment by molly.mc...@gmail.com on 3 Dec 2007 at 8:00

Attachments:

GoogleCodeExporter commented 9 years ago

I think I'm done, I have ~78% coverage. GTG

Original comment by molly.mc...@gmail.com on 3 Dec 2007 at 11:07

Attachments:

GoogleCodeExporter commented 9 years ago

This task is due Tuesday, December 4, 2007 at 00:35:00 UTC.

Original comment by doug.hel...@gmail.com on 4 Dec 2007 at 5:33

Added labels: Due-20071204

GoogleCodeExporter commented 9 years ago

Original comment by georg.br...@gmail.com on 4 Dec 2007 at 9:29

Added labels: FollowupBy-titus

GoogleCodeExporter commented 9 years ago

Sorry, this got lost in my todo list.  Will look at it tomorrow.

Original comment by the.good...@gmail.com on 6 Dec 2007 at 9:35

GoogleCodeExporter commented 9 years ago

Original comment by doug.hel...@gmail.com on 7 Dec 2007 at 1:16

Added labels: NeedsReview

GoogleCodeExporter commented 9 years ago

Original comment by doug.hel...@gmail.com on 7 Dec 2007 at 1:27

Added labels: Due-20071204.0035
Removed labels: Due-20071204

GoogleCodeExporter commented 9 years ago

Original comment by georg.br...@gmail.com on 7 Dec 2007 at 9:00

Added labels: Due-20071207.0035, expired
Removed labels: Due-20071204.0035

GoogleCodeExporter commented 9 years ago

Heh, I like that you found a bug in pyfacebook ;).  I haven't gotten a response 
from
the authors of pyfacebook yet, though.

Your tests are good, and all that I would ask is that you either rename the 
unittest
functions from test? to something more meaningful OR provide docstrings saying 
what
they're testing.  (preferably both)

I apologize again for the delay in reviewing your code.  Nice job.

Original comment by the.good...@gmail.com on 7 Dec 2007 at 9:29

GoogleCodeExporter commented 9 years ago

Original comment by doug.hel...@gmail.com on 7 Dec 2007 at 10:47

Changed state: ActionNeeded

GoogleCodeExporter commented 9 years ago

Hi,

The tests look good. I'll commit this to SVN as soon as I have a chance (lots
of finals and such going on right now). Also, good job finding the bug :-P

Thanks for the work on this,

Samuel Cormier-Iijima

Original comment by sciyoshi on 8 Dec 2007 at 4:06

GoogleCodeExporter commented 9 years ago

OK, if Samuel is happy that's good enough for me!

Original comment by the.good...@gmail.com on 8 Dec 2007 at 10:09

Changed state: Completed
Removed labels: NeedsReview, expired

GoogleCodeExporter commented 9 years ago

Original comment by georg.br...@gmail.com on 12 Dec 2007 at 7:28

Removed labels: Due-20071207.0035, FollowupBy-titus