dhemery / DHE-Modules

VCV rack modules from Dale Emery
MIT License
33 stars 2 forks source link

build error with latest pull #27

Closed davephillips closed 3 years ago

davephillips commented 3 years ago

Ubuntu 18.04 Linux VCV Rack CE v2.git.219bbaf1

Hi Dale !

Got this error from this morning's pull:

$ make
g++  -std=c++11 -Wsuggest-override  -Isrc -fPIC -I../../include -I../../dep/include -fno-gnu-unique -MMD -MP -g -O3 -march=athlon-fx -funsafe-math-optimizations -Wall -Wextra -Wno-unused-parameter -DARCH_LIN  -c -o build/src/plugin.cpp.o src/plugin.cpp
In file included from src/modules/curve-sequencer/init.h:3:0,
                 from src/plugin.cpp:4:
src/modules/curve-sequencer/panel.h:97:71: error: declaration of ‘using Signals = struct dhe::curve_sequencer::Signals<rack::engine::Input, rack::engine::Output, rack::engine::Param, rack::engine::Light, dhe::curve_sequencer::Panel<TSize>::N>’ [-fpermissive]
                           rack::engine::Param, rack::engine::Light, N>;
                                                                       ^
In file included from src/modules/curve-sequencer/module.h:7:0,
                 from src/modules/curve-sequencer/init.h:2,
                 from src/plugin.cpp:4:
src/modules/curve-sequencer/signals.h:24:8: error: changes meaning of ‘Signals’ from ‘struct dhe::curve_sequencer::Signals<rack::engine::Input, rack::engine::Output, rack::engine::Param, rack::engine::Light, dhe::curve_sequencer::Panel<TSize>::N>’ [-fpermissive]
 struct Signals {
        ^~~~~~~
../../compile.mk:69: recipe for target 'build/src/plugin.cpp.o' failed
make: *** [build/src/plugin.cpp.o] Error 1

Any suggestions for fixing ?

dhemery commented 3 years ago

That line was both incorrect and unnecessary. I deleted it.

I'm testing (in GitHub) on Ubuntu 20.04. Please let me know if this fix works for you on 18.04.

Thanks for your report!

davephillips commented 3 years ago

Yes, it works on 18.04. Thanks for the quick fix, and thank you for the excellent modules.