dhenry-KCI / TMDL-_Tracking-Widget

TMDL Tracking Widget
0 stars 0 forks source link

Export Functionality (TMDL_Widget) 6.12 - exports too many records #102

Open BrittanyHuber opened 10 years ago

BrittanyHuber commented 10 years ago

When exporting features to both excel and geodatabase formats, the files contain too many records.

249results

480resultsexcel

gdb480

Steps to recreate: Selection > Form Select by TMDL Strategies > Planting Trees Filter by Geography > District 4 > Baltimore 249 results > export to excel > 480 records (not all within district 4) export to geodatabase > 480 records (not all within district 4)

BrittanyHuber commented 9 years ago

Tara,

EFF_BMP site selection is not exporting the correct number of features either. In district 2, Cecil county I selected all TMDL site selections, then exported all feature types. EFF_BMP only exported 621 files, but when I went back to the selection tab and selected just EFF_BMP site selection, it returns 619 sites. The rest of the asset types exported the correct number of features.

Also, when selecting all TMDL Strategies (assets) then select all features to export to excel, it is not exporting at all.

Brittany

TaraF commented 9 years ago

When selecting all TMDL Strategies (or Site Selections), it takes the script some time to run through each. I watched the network trace, and it did eventually finish the export successfully. Do you recommend having a message show up for the user that the script is still processing while it is running? If so, should that be an enhancement?

I see the same discrepancy in the TMDL site selection EFF_BMP (621 vs 619). I am looking into this.

I am still investigating the original issue.

BrittanyHuber commented 9 years ago

While researching the following issue: site selections > EFF_BMP site selection > District 2 > Cecil county > exports 619 records site selections > All tmdl site selections > District 2 > Cecil county > EFF_BMP exports 621 records

The export with 621 records includes 2 sites from Carroll County (0600001 and 0600002). Checked in the database for an underlying data issue and have not identified the issue yet. Still continuing to look into this.

I tested other counties and other assets/site selections and I have not encountered this issue with any others.

BrittanyHuber commented 9 years ago

@TaraF for the following issue: site selections > All tmdl site selections > District 2 > Cecil county > EFF_BMP exports 621 records (should be 619). This includes 2 sites from Carroll County (0600001 and 0600002).

In the widget when you select by all site selections in cecil county, 0600001 and 0600002 are excessive land site selection sites that are included because they are populated with the wrong county code (say cecil - should say carroll). They display all of the attribute information that is relevant to the excessive land site selection sites. If you export only excessive land sites, they export with the correct information.

However, 0600001 and 0600002 are also EFF_BMP_SITE_SELECTION site ID's, so when exporting only EFF_BMP_SITE_SELECTION, it exports sites 0600001 and 0600002 with the attribute information from the EFF_BMP_SITE_SELECTION sites.

I tested another county with the same STRU_ID's in both excessive land site selection and eff_bmp_site_selection, and did not encounter the same issue.

Let me know if this is confusing!

Brittany

TaraF commented 9 years ago

The new change being implemented for EFF_BMP SS features, is that they will be pulled from the EFF_BMP_PLANNED table. I believe, based on what i see in the DB, that these two records should not be selected, as they are not found in the planned table at this time.

That, and possible in part a data issue (wrong CO assignment?) are causing this issue. The script itself seems to be working fine, as it is working for other EFF_BMPs fine, and that the services are directly picking up these two out of county records -- which then feed directly to the script.

I recommend keeping this issue open, until we can confirm that the new services eliminate this issue. Please check when latest code is pushed to SHA.

ehsan67 commented 9 years ago

@TaraF @BrittanyHuber @dhenry-KCI I checked the backend and realized I was using EFF_BMP_SITe_SELECTION attributes to get the result for that Geography queries. I changed it to EFF_PLANNED_BMP . Please let me know if that fixed the problem

ehsan67 commented 9 years ago

The result returns 522 records for County = 07