You've mixed the assert() changes with the README changes. You should make these separate pull requests.
The macros around assert() are unnecessary. You can simply add -DNDEBUG to the Makefile and the assert()s will be compiled out.
This project is intended more to be used as part of a larger project, which is why it's in the public domain; and as such, the most important thing is that it can be demonstrated to work 100% correctly without bugs, which is why the assert()s are enabled by default. If you're comfortable with the code and you want to use it without the assert()s, you should just copy it into your project and make whatever changes you want there.
That said, I would accept either of these (separate) patches as long as the -DNDEBUGMakefile patch is commented out by default.
Thanks. I have two comments:
assert()changes with the README changes. You should make these separate pull requests.assert()are unnecessary. You can simply add-DNDEBUGto theMakefileand theassert()s will be compiled out.This project is intended more to be used as part of a larger project, which is why it's in the public domain; and as such, the most important thing is that it can be demonstrated to work 100% correctly without bugs, which is why the
assert()s are enabled by default. If you're comfortable with the code and you want to use it without theassert()s, you should just copy it into your project and make whatever changes you want there.That said, I would accept either of these (separate) patches as long as the
-DNDEBUGMakefilepatch is commented out by default.