added bind_ringbuffer for embedded systems with static memory and added good stuff of othes

dhess / c-ringbuf

A ring buffer implemented in C

Other

418 stars 143 forks source link

added bind_ringbuffer for embedded systems with static memory and added good stuff of othes #9

Closed levush closed 5 years ago

levush commented 6 years ago

added bind_ringbuffer for embedded systems with static memory where there is no malloc, so a ring buffer can be bound to existing memory blocks, e.g. arrays. Also I added good stuff of other forks, So this code would be a good starting point for further development.

dhess commented 6 years ago

I tried to comment on each change in this PR individually, but I'm not sure I did it correctly as I'm not familiar with that part of the GitHub interface. In any case, both the thread read/write support change and the RINGBUF_NO_ASSERT changes were previously rejected, so I must reject those again.

I will need to take a closer look at the ringbuf_bind changes. (For starters, there appears to be an obvious bug in ringbuf_bind; see my comment on the diff.)

dhess commented 5 years ago

The new changes you've made in your fork, specifically changing all of the function names, make this PR no longer feasible, so I'm going to reject it.