dhewg / esphome-miot

ESPHome components for MIoT devices
Other
42 stars 17 forks source link

fix ota compile error for esphome > v24.6.0 #25

Closed 9R closed 2 months ago

9R commented 4 months ago

This is an alternate solution for the OTA compile error addressed in #24 making use of the new esphome function get_global_ota_callback based on how the changes in the OTA component are handled in the esphome codebase.

scrampker commented 4 months ago

I'm feeling kind of dumb here -- but how does one use a specific branch on github to replace the official miot until it's merged properly? I'd be fine manipulating the files locally, but I can't seem to find them in the VS addon or terminal.

cristianchelu commented 4 months ago

I'm feeling kind of dumb here -- but how does one use a specific branch on github to replace the official miot until it's merged properly? I'd be fine manipulating the files locally, but I can't seem to find them in the VS addon or terminal.

The syntax is github://owner/project-name@branch, which in this case is:

external_components:
  source: github://9R/esphome-miot@main

docs: https://esphome.io/components/external_components.html#external-components

As long as this branch exists you don't really have to clone anything locally. Hope this helps.

scrampker commented 4 months ago

Thanks!

9R commented 4 months ago

Just to add to @cristianchelu answer, because including a gitrepo from a random stranger on the internet could be viewed as a security risk, since unwanted changes would be pull in without review on future builds of esphome: It is possible to use a local checkout of a repo quite easily:

git clone github://9R/esphome-miot /path/to/desired/local/repo/location

In your esphome yaml:

external_components:
  source: file:///path/to/desired/local/repo/location

Alternatively you could set refresh: never on an online repo. Check the linked documentation above for details.

scrampker commented 4 months ago

Perfect thanks. Also I'm trying to add fan functionality to miot, so I forked it to my own account. Another option until the official is fixed.

dhewg commented 2 months ago

Thanks, and sorry for the massive delay!