search

dhewm / dhewm3

dhewm 3 main repository
https://dhewm3.org/
GNU General Public License v3.0
1.78k stars 346 forks source link

Severe performance regression due to soft particles in 1.5.4 #604

Open user21944 opened 1 month ago

user21944 commented 1 month ago

1.5.4 has significantly higher GPU usage than 1.5.3 whenever particles are on screen, going from ~35% to over 80% on my system (Ryzen 5 5600G, Vega 8 iGPU on Windows). This is caused by soft particles, which are now enabled by default.

I'm not sure if the poor performance on my system is a symptom of my hardware or a bug/optimization issue. Regardless, soft particles should probably be disabled by default so that unaware users aren't faced with significant performance degradation after updating (especially on Intel iGPUs where performance is already limited).

No soft particles, 36% usage: image No soft particles, capture depth buffer to texture, 40% usage: image Soft particles, 80% usage: image Performance is the same in both windowed and fullscreen, windowed was used here to take a screenshot

xmansch commented 1 month ago

,

1.5.4 has significantly higher GPU usage than 1.5.3 whenever particles are on screen, going from ~35% to over 80% on my system (Ryzen 5 5600G, Vega 8 iGPU on Windows). This is caused by soft particles, which are now enabled by default.

I'm not sure if the poor performance on my system is a symptom of my hardware or a bug/optimization issue. Regardless, soft particles should probably be disabled by default so that unaware users aren't faced with significant performance degradation after updating (especially on Intel iGPUs where performance is already limited).

No soft particles, 36% usage: image No soft particles, capture depth buffer to texture, 40% usage: image Soft particles, 80% usage: image Performance is the same in both windowed and fullscreen, windowed was used here to take a screenshot

what about perfomance, when you disable soft particales ?

DanielGibson commented 4 weeks ago

I'm not sure I want to disable this by default - do you think it would be sufficient if it were disabled when setting a Performance Preset below Ultra? That would mean that it's still enabled by default, but if someone sets the performance preset to "high" or "medium" or "low" (because performance is bad on their system), soft particles get disabled. Because of how those performance presets work, having it already set to high won't disable it, though (that would be bad, because you want to allow people to select a preset and then tweak a few settings afterwards)

user21944 commented 3 weeks ago

I'm not sure I want to disable this by default - do you think it would be sufficient if it were disabled when setting a Performance Preset below Ultra? That would mean that it's still enabled by default, but if someone sets the performance preset to "high" or "medium" or "low" (because performance is bad on their system), soft particles get disabled. Because of how those performance presets work, having it already set to high won't disable it, though (that would be bad, because you want to allow people to select a preset and then tweak a few settings afterwards)

I guess that would be fine. It just seems like this feature is very expensive for what it does