search

dhhagan / py-opc

Python wrapper for the Alphasense OPC-N2 built around py-spidev
MIT License
30 stars 26 forks source link

Implementation of OPCR1 #82

Open FlorentinBulotAQ opened 5 years ago

FlorentinBulotAQ commented 5 years ago

Hello,

I have written an implementation for the OPC-R1. I have tested methods: on(), off(), histogram() and reset(). I have not yet tested the other methods.

Would it be possible to publish it?

With best wishes, Florentin.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-2.3%) to 13.676% when pulling edd78addce9ca827342b241e570881319e0cb7db on FlorentinBulotUoS:master into 2c8f19530fb64bf5fd4ee0d694a47850161ed8a7 on dhhagan:master.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-2.3%) to 13.676% when pulling 9dfae9d408adecac5b4c2815689ff702f67696ff on FlorentinBulotUoS:master into 2c8f19530fb64bf5fd4ee0d694a47850161ed8a7 on dhhagan:master.

FlorentinBulotAQ commented 5 years ago

I do not know much about code coverage. Do you have a script with unit testing that I should add methods to ?

dhhagan commented 5 years ago

Hi @FlorentinBulotUoS - don't worry about the code coverage - hardware products are difficult to test in this way (at least in my experience). I'll check the code and merge the PR after my committee meeting today. Thanks!

FlorentinBulotAQ commented 5 years ago

Hi @dhhagan,

Let me know if there is any issue with the code for me to fix.

With best wishes.

dhhagan commented 5 years ago

Hey @FlorentinBulotUoS I will do my best to get to this tonight/tomorrow - currently swamped trying to finish up a manuscript...

dhhagan commented 5 years ago

Hey @FlorentinBulotUoS Thanks so much for this work - I'm almost done going through it and will give any feedback if needed, otherwise I will merge it in to master. If possible, it would be ideal to have more than 1 person test it before the actual release to pip - do you know of anyone else who could test it? If not, I can try to reach out to Alphasense...

FlorentinBulotAQ commented 5 years ago

Hi @dhhagan, thanks a lot for going through the code. I will check with one of my colleague who may be able to test it on Friday. I have sent the code to Alphasense last week but I have not heard back from them yet (although I have not asked them explicitly if they could test it...).

FlorentinBulotAQ commented 5 years ago

Hi @dhhagan, sorry for the late answer. I have done the changes you have requested. The code has not been tested yet by somebody other than me. Let me know if everything is fine with it.

Kind regards

FlorentinBulotAQ commented 5 years ago

Hi @dhhagan,

I have fixed a couple of issues that appeared while running the code for an extended period of time on multiple OPCR1. I have also fixed the read_config() and pm() methods which were broken. I was wondering if you could merge it with the master so people can test it?

Thanks a lot, With best wishes.

Smeedy commented 4 years ago

Hi there,

I was looking for the OPC-N3 implementation. You are talking about the OPC-R1, which on the product page is mentioned in the last alinea. They switch from OPC-N3 to OPC-R1. This is the same device?

I have 6 of them here up for testing and will look at code and lab results if we are indeed talking about the same device.

cheers

FlorentinBulotAQ commented 4 years ago

Hi @Smeedy ,

The OPC-R1 and the OPC-N3 are two different models. The OPC-N3 is more expensive and can measure particles <40um diameter while the OPC-R1 measures particles <10um.

I do not know whether they use the same commands though so I am not sure whether the implementation of the OPC-R1 will work for the OPC-N3. I do not have any OPC-N3 to test it so I cannot tell you more.

I hope that helps, With best wishes

FlorentinBulotAQ commented 4 years ago

Dear contributors,

Just to let you know that I needed to reference the software for the OPC-R1 so have made a release of my fork for the OPC-R1 and have obtained a DOI for it: https://zenodo.org/record/3571966

I have used the information I had on GitHub about each of you. Let me know if you want me to edit your details on the DOI (names, ORCID and affiliations).

With best wishes, Florentin.