default log store backend to WAL and allow disabling verification

dhiaayachi / consul

Consul is a distributed, highly available, and data center aware solution to connect and configure applications across dynamic, distributed infrastructure.

https://www.consul.io

Other

0 stars 0 forks source link

default log store backend to WAL and allow disabling verification #105

Open dhiaayachi opened 1 week ago

dhiaayachi commented 1 week ago

Description

This PR change the default log store config to use WAL when starting with a fresh database. If a bolt db already exist bolt db will be used as a backend and a warning will be logged.

It also allow the log verifier, enabled by default, to be disabled.

Testing & Reproduction steps

Added tests to verify combination of configs.

PR Checklist

[x] updated test coverage
[x] external facing docs updated
[x] appropriate backport labels added
[x] not a security concern

dhiaayachi commented 1 week ago

Thank you for your contribution! This PR looks great and I'm happy to see the improvements you've made to the log store configuration.

I especially like the addition of the option to disable the log verifier. This gives users more control over the trade-offs between performance and consistency.

I'm also pleased to see the thorough testing and documentation updates.

Thanks again for your hard work!