feat(v2dns): add partial support for SOA records - Githubissues

dhiaayachi / consul

Consul is a distributed, highly available, and data center aware solution to connect and configure applications across dynamic, distributed infrastructure.

https://www.consul.io

Other

0 stars 0 forks source link

feat(v2dns): add partial support for SOA records #1295

Open dhiaayachi opened 1 month ago

dhiaayachi commented 1 month ago

Description

This PR adds partial support for SOA records. SOA records are return in these cases:

When an SOA query type is used. Nameservers are also provided in this case.
When there is a valid query name but no data to return.

The necessary code paths for this record type are implemented, but not the fetching of nameservers, which will come in a subsequent PR.

Testing & Reproduction steps

Unit tests are added with mock QueryProcessors
V1 DNS tests - there weren't any to enable here. They all involve hitting the catalog in one way or another.

PR Checklist

[X] updated test coverage
[ ] ~external facing docs updated~
[X] appropriate backport labels added
[X] not a security concern