fix 403 and filtering when retrieving balances using the API

dhiaayachi / go-newton-co

go api for newton.co bitcoin exchance

Apache License 2.0

4 stars 0 forks source link

fix 403 and filtering when retrieving balances using the API #3

Closed p0mvn closed 3 years ago

p0mvn commented 3 years ago

Related to #2 that I opened earlier. I tested other API functions such us "Get Order History", and they all return 400 at the moment. @dhiaayachi if you are still active in this repo and review my PRs, I can go ahead and fix some of them

dhiaayachi commented 3 years ago

Hi @akhtariev I did not test it for a while and I'm not able to automate testing because Newton don't offer a testing sandbox, but I will gladly review and accept PRs

dhiaayachi commented 3 years ago

Thank you for this change @akhtariev I will run the tests tonight and if everything pass I will merge it

p0mvn commented 3 years ago

@dhiaayachi sounds great! Thanks! I will work on some changes in the next few days then and open more PRs. I'm working on a project where I need to import transaction data and balances so it would be great if I could just reuse this API instead of copying the logic

p0mvn commented 3 years ago

Awesome, thanks for reviewing and fixing the rest of the tests! Yeah, I can work on the public API this week. I will open a PR once it's ready