dhiaayachi / temporal

Temporal service
https://docs.temporal.io
MIT License
0 stars 0 forks source link

Change metrics name or allow to configure prefix #169

Open dhiaayachi opened 2 months ago

dhiaayachi commented 2 months ago

Is your feature request related to a problem? Please describe. Hey, guys. We encountered the following problem while configuring metrics for self hosted cluster. Metrics are not labeled with a special prefix, so there is no grouping for hundreds of metrics. This in turn makes it confusing, because it is not clear whose metrics they are exactly

The example on the screen from google cloud monitoring.

image image

Describe the solution you'd like It would be cool if all metrics could be grouped under a common label, like Temporal, TemporalWorker, TemporalPoll, etc, so as not to pollute the overall scope.

Describe alternatives you've considered On the other hand, it's a pretty breakable change. It may be possible to specify a prefix through env variables, which will be empty by default (for backward compatibility), which anyone can specify and thus change the name of metrics in monitoring systems if desired

dhiaayachi commented 1 month ago

Thank you for reporting this issue. This issue is likely due to the lack of a common label for Temporal metrics. As you noted, this can be confusing as there are no inherent groupings for metrics when viewing them in your monitoring system.

This issue is a feature request, so we don't have an immediate fix available. However, your suggested solution of using environment variables is an interesting and valid way to work around this issue.

You can use a script to scrape the metrics from your Temporal Service and then prefix them with your desired label. This approach can be tailored to work with various monitoring systems.

This approach isn't ideal, but it does offer a way to work around the current lack of a native solution. We are committed to building a better solution for grouping and labeling Temporal metrics. We welcome your feedback, so that we can make it a priority in a future release.

dhiaayachi commented 1 month ago

Thank you for reporting this issue.

Based on the documentation you provided, the metrics are labeled with the Temporal namespace.

Let me know if you have any questions.