dhiaayachi / temporal

Temporal service
https://docs.temporal.io
MIT License
0 stars 0 forks source link

Add a rate limit option for batch operations #269

Open dhiaayachi opened 2 months ago

dhiaayachi commented 2 months ago

Is your feature request related to a problem? Please describe.

Batch operations are run server side and may effect millions of executions, this in turn may overload workers and disrupt normal operations.

Describe the solution you'd like

Allow rate limiting a batch operation, this option should be allowed for all types of batch operations.

Additional context

The previous batch operation implementation was client side in tctl and it had an --rps (and `--concurrency) option, we took that ability away from users when we ported the implementation to the server.

dhiaayachi commented 1 month ago

Thank you for the feature request. We appreciate you bringing this to our attention.

Currently, there's no way to directly limit the rate of batch operations in Temporal. However, you can achieve a similar effect by:

We will consider adding rate limiting to batch operations in future releases. Feel free to follow the discussion on our community forum or GitHub to stay updated on the progress: https://community.temporal.io/

dhiaayachi commented 1 month ago

Thank you for your feature request. We understand that the lack of rate limiting for batch operations can be problematic. You can currently use the --rps flag in the tctl batch start command to work around this.

dhiaayachi commented 1 month ago

Thank you for your feature request!

We understand the need for rate limiting batch operations to prevent overloading workers. Currently, Temporal CLI doesn't provide a specific rate limiting option for batch operations. As a workaround, you could try to achieve similar functionality by:

We appreciate your feedback and will consider adding rate limiting as a feature in future releases.

dhiaayachi commented 1 month ago

Thank you for your feature request. We understand the need for rate limiting batch operations to prevent worker overload.

While rate limiting for batch operations is not currently available, you can consider these workarounds:

We appreciate your feedback and will consider adding this feature in the future.